chore(style): minor code style adjustments for improved consistency#152
chore(style): minor code style adjustments for improved consistency#152AriPerkkio merged 5 commits intomainfrom
Conversation
|
|
| dataLayer.push(arguments); | ||
| } | ||
|
|
||
| // @ts-ignore |
There was a problem hiding this comment.
@Nemikolh Would be cool if we can explain why we do this. Feel free to push to this branch.
// @ts-ignore because ...
There was a problem hiding this comment.
For consistency we could use https://typescript-eslint.io/rules/ban-ts-comment/#allow-with-description
There was a problem hiding this comment.
That is something we should even add to our eslint plugin IMHO.
There was a problem hiding this comment.
When exactly do these @ts-ignore here become required? If I remove them from this PR, all tests and builds pass just fine.
There was a problem hiding this comment.
Oh right, pnpm docs:build did fail https://github.com/stackblitz/tutorialkit/actions/runs/10004035387/job/27651984509?pr=152
Deploying tutorialkit-docs-page with
|
| Latest commit: |
3a400ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://66ab711a.tutorialkit-docs-page.pages.dev |
| Branch Preview URL: | https://delm-chore-style-consistency.tutorialkit-docs-page.pages.dev |
There was a problem hiding this comment.
Oh this file is completely redone in #143, maybe you want to review that one instead?
There was a problem hiding this comment.
Oh interesting, yea maybe we don't have to fix it then?
There was a problem hiding this comment.
Yeah but the other PR might have issues
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good to me. Ideally this kind of changes would be automated with linter and formatters. 👍
|
Yea, some things are harder to automate but I agree with you. The more we can automate the better! |
|
@d3lm as follow-up I can file a PR against our ESLint plugin to add these improvements. |
|
That would be wonderful Air! |
|
Looks like |
3 participants
Small PR that updates some minor code styling to streamline consistency with the rest of the repo.