feat(extension): metadata autocompletion#143
Conversation
|
|
Nemikolh
force-pushed
the
joan/frontmatter-completions
branch
from
c3dbda2 to
63ece9e
Compare
Deploying tutorialkit-demo-page with
|
| Latest commit: |
0966dcf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0c04146.tutorialkit-demo-page.pages.dev |
| Branch Preview URL: | https://joan-frontmatter-completions.tutorialkit-demo-page.pages.dev |
Nemikolh
force-pushed
the
joan/extensions-ci-and-tiny-fixues
branch
from
aff6bbe to
95e8acf
Compare
Nemikolh
force-pushed
the
joan/frontmatter-completions
branch
from
7005e34 to
1d4cfa1
Compare
| // TODO: those don't work | ||
| 'src/content/*.md', | ||
| 'src/content/**/*.md', | ||
| 'src/content/**/*.mdx', |
There was a problem hiding this comment.
I still need to investigate that, ideally I don't want the check to apply to every markdown & mdx files.
| }, | ||
| }); | ||
|
|
||
| delete yamlService.capabilities.codeLensProvider; |
There was a problem hiding this comment.
I removed that because otherwise the schema was popping up on each file metadata. It wasn't a really great UX.
Deploying tutorialkit-docs-page with
|
| Latest commit: |
0966dcf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f829b4a.tutorialkit-docs-page.pages.dev |
| Branch Preview URL: | https://joan-frontmatter-completions.tutorialkit-docs-page.pages.dev |
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Tested this locally and it works really nice, like magic! 🪄
The code itself looks fine to me. I haven't used Volar before but the integration looks clear. @d3lm do you want to take a look at this before I merge this?
|
Yep can take a look if you want 👍 |
d3lm
left a comment
d3lm
left a comment
There was a problem hiding this comment.
Nice work! Left a few minor remarks. Since @Nemikolh is OOO this week, do you wanna take a stab at the comments @AriPerkkio or do we wanna wait?
I'll handle the PR comments next. 👍 |
d3lm
left a comment
d3lm
left a comment
There was a problem hiding this comment.
Last small remarks but looking good!
|
Tested extension manually after the latest changes. Works OK. ✅ |
3 participants
This PR adds a volar based language server to provide autocompletion in the metadata of markdown and mdx files.
All the
describeproperties are here to provide a description for each property.The autocompletion features is entirely provided by the Yaml language server.
TutorialKit-metadata-intellisense.webm