Remove openshift start node and cut kubelet dependencies#20344
Remove openshift start node and cut kubelet dependencies#20344openshift-merge-robot merged 6 commits intoopenshift:masterfrom
openshift start node and cut kubelet dependencies#20344Conversation
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
smarterclayton
force-pushed
the
goodbye_kubelet
branch
6 times, most recently
from
728864e to
4b3bf59
Compare
|
/test gcp |
smarterclayton
force-pushed
the
goodbye_kubelet
branch
from
4b3bf59 to
20cf431
Compare
|
/test gcp |
3 similar comments
|
/test gcp |
|
/test gcp |
|
/test gcp |
|
/retest |
|
@deads2k this is ready for review |
|
@smarterclayton I'm ready if you are. 3.11? /test all |
openshift-bot
added
the
needs-rebase
smarterclayton
force-pushed
the
goodbye_kubelet
branch
from
20cf431 to
4ba500a
Compare
openshift-bot
removed
the
needs-rebase
smarterclayton
force-pushed
the
goodbye_kubelet
branch
3 times, most recently
from
27e65c9 to
62ce9e5
Compare
|
I think we should do this in 3.11 |
| Run: func(c *cobra.Command, args []string) { | ||
| kcmdutil.CheckErr(options.Complete()) | ||
|
|
||
| if options.PrintIP { |
There was a problem hiding this comment.
Eventually this will go away too. Why move it here?
There was a problem hiding this comment.
We still need it for like a billion test cases and tests. Everything using start went to using start master, so I moved it here.
| "github.com/openshift/origin/pkg/version" | ||
| ) | ||
|
|
||
| type NodeOptions struct { |
There was a problem hiding this comment.
name isn't correct anymore
test/util/server/server.go
Outdated
| } | ||
|
|
||
| if err := start.StartNode(*nodeConfig, components, wait.NeverStop); err != nil { | ||
| if err := start.StartNode(*nodeConfig, components); err != nil { |
There was a problem hiding this comment.
This is starting the network?
There was a problem hiding this comment.
Yes, I can rename.
|
Some questions. Nothing fundamental. |
smarterclayton
force-pushed
the
goodbye_kubelet
branch
from
62ce9e5 to
55fd30f
Compare
smarterclayton
force-pushed
the
goodbye_kubelet
branch
from
55fd30f to
0ac2242
Compare
|
Did the renames |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
The kubelet is now only launched via
hyperkube kubelet. Removeopenshift start.