Update 3.11 for openshift start / hyperkube changes#21268
Update 3.11 for openshift start / hyperkube changes#21268adellape merged 1 commit intoopenshift:enterprise-3.11from
openshift start / hyperkube changes#21268Conversation
b03989e to
3ffde0b
Compare
|
@deads2k Could you PTAL at this 3.11 docs fix re: Origin issue "Remove openshift start node and cut kubelet dependencies" openshift/origin#20344 so we can get it merged? Thank you! |
|
Adding peer review acks as they were given in the original PR #18691. |
|
@wangke19 Can you take a look at this for QE review, please? Thank you! |
|
I will ask @xingxingxia to review together. |
xingxingxia
left a comment
There was a problem hiding this comment.
@adellape Hi, LGTM except the inline comments. For some lines which are not in my areas (my areas are Master / Apiserver), already requested related subteams QE inline to double confirm.
There was a problem hiding this comment.
Can you double confirm these other doc pages are desired? I just see these configuration file or configuration maps are in the same doc page ../install_config/master_node_configuration.html
There was a problem hiding this comment.
Strange wording in the in
There was a problem hiding this comment.
I didn't see admin_guide/manage_nodes.adoc#modifying-nodes mentions log level, is this link good?
There was a problem hiding this comment.
Fixed typo and removed link.
There was a problem hiding this comment.
I'd like to request Networking QE @zhaozhanqi to double confirm for openshift start network
Reopening #18691 against
enterprise-3.11branch.Original description:
Fixes #11751.
Per https://github.com/openshift/origin/releases/tag/v3.11.0:
Preview (internal):