test: change from setTimeout to setImmediate#9578
Closed
fossamagna wants to merge 1 commit intonodejs:masterfrom
Closed
test: change from setTimeout to setImmediate#9578fossamagna wants to merge 1 commit intonodejs:masterfrom
fossamagna wants to merge 1 commit intonodejs:masterfrom
Conversation
This is a part of Code And Learn at NodeFest 2016 Challenge
mscdex
added
the
timers
Member
|
CI is green, LGTM |
Contributor
|
CI is running on https://ci.nodejs.org/job/node-test-pull-request/4830/. |
shigeki
approved these changes
Nov 12, 2016
Contributor
shigeki
left a comment
shigeki
left a comment
There was a problem hiding this comment.
One test failure is due to missing g++ path on CentOS7-64. Others are green. LGTM.
cjihrig
approved these changes
Nov 12, 2016
shigeki
pushed a commit
that referenced
this pull request
Nov 13, 2016
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: #9578 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Contributor
|
Thanks. Landed in 8a78fcb. |
4 tasks
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: #9578 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: nodejs#9578 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: #9578 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: #9578 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: #9578 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
This is a part of Code And Learn at NodeFest 2016 Challenge
nodejs/code-and-learn#58