test: change from setTimeout to setImmediate#9575
Closed
nao215 wants to merge 1 commit intonodejs:masterfrom
Closed
test: change from setTimeout to setImmediate#9575nao215 wants to merge 1 commit intonodejs:masterfrom
nao215 wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
CI is running on https://ci.nodejs.org/job/node-test-pull-request/4829/. |
cjihrig
approved these changes
Nov 12, 2016
Contributor
|
@nao215 I would like you to confirm if you missed to setup git username. You can write it your screen name on your github profile. Just confirmation. |
lpinca
approved these changes
Nov 13, 2016
Change test method from setTimeout to setImmediate. This is a part of Code And Learn at NodeFest 2016 Challenge
nao215
force-pushed
the
fix-test-stream-unshift-read-race
branch
from
6fd7560 to
76dd90d
Compare
Author
|
@shigeki Thanks. I wrote my screen name and pushed!! |
Contributor
|
@nao215 Sorry, your fix has already applied in #9578. Looking at nodejs/code-and-learn#58 (comment) , you are later than that. I should have told you more earlier. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Change test method from setTimeout to setImmediate.
This is a part of Code And Learn at NodeFest 2016 Challenge