build: use --whole-archive for pthread with --fully-static

[addaleax]

This resolves a crash during the build of Node.js when built
with ./configure --fully-static.

Fixes: #30180

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[gengjiawen]

Is possible to add a CI job for this ? Possible can be done via #30057

[addaleax]

@gengjiawen I guess, but I think that’s something someone else might have to do :)

[gireeshpunathil]

ping @addaleax - is this stuck because there is not a proper CI job to test this, or any other concerns w.r.t the change itself?

edit - I see recent conversations on this PR, so stuck may be a little off to use!

[addaleax]

@gireeshpunathil It’s stuck because it isn’t at the top of my priority list :)

is this stuck because there is not a proper CI job to test this, or any other concerns w.r.t the change itself?

Neither. CI doesn’t pass because this doesn’t work on all platforms; I assume the next step would be to figure out which platforms those are and how to turn that into a condition in the gypfile.

Fresh CI: https://ci.nodejs.org/job/node-test-commit/34986/

[BethGriggs]

Rerunning CI to see which platforms are failing - I've seen a report (outside of GH) of another user hitting an error when building with --fully-static, and it appears to be fixed by this PR.

From a suggestion from @miladfarca, ['-static', '-no-pie'] allows my --fully-static build to complete on Alpine too. I've only tested that in an Alpine Docker container on S390x, though.

CI: https://ci.nodejs.org/job/node-test-commit/40593

[alexnagelberg]

CI doesn’t pass because this doesn’t work on all platforms; I assume the next step would be to figure out which platforms those are and how to turn that into a condition in the gypfile.

How is it passing without the patch? It literally won't build at all with the fully static option.

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.