build,test: add .ci.yml for containered tests (WIP proposal)

[rvagg]

I'm working up a proposal for Build, this can be safely ignored for now, I'll be getting the rest of it up and documented in nodejs/build for further discussion.

[rvagg]

Documentation for this PR is currently @ nodejs/build#1982, this PR serves as part of that proposal. "Show all checks" below in GitHub's status checks shows some of what this is doing.

[gengjiawen]

Also any thought on add ./configure --debug -C for general check (no need to build).

[rvagg]

Also any thought on add ./configure --debug -C for general check (no need to build).

That'd be fine, these quick checks, like the linter, are ideal to add in here since they are cheap. You just need to have a validation to make sure it's acutally worked. Returning a non-zero exit code is one thing, but has it done what it's supposed to? Maybe you could work up a proposal for how to run and check that?

btw, putting CMake into the standard Ubuntu 18.04 container, like Ninja is, would make it possible to run full CMake builds with this too, which might be a step in a positive direction.

[gengjiawen]

Is it okay to write those two as env variable in docker image ?

[cclauss]

Impressive!

[gengjiawen]

@rvagg Is there any left work to do ? Can we mark this as ready ?

[richardlau]

@rvagg Is there any left work to do ? Can we mark this as ready ?

@gengjiawen It's not ready, see nodejs/build#1982 (comment)

[cclauss]

Shouldn't PYTHON be defined before running make instead of after?

[richardlau]

You can do either.

PYTHON=python2 make lint-ci

Sets the PYTHON environment variable in the shell and runs make, which turns environment variables into make variables: https://www.gnu.org/software/make/manual/html_node/Environment.html#Environment

make lint-ci PYTHON=python2

Overrides the make variable from the command line: https://www.gnu.org/software/make/manual/html_node/Overriding.html

[BridgeAR]

Ping @rvagg

[BridgeAR]

Ping @rvagg

[jasnell]

Ping @rvagg (again :-) ...)

[rvagg]

I've tried and tried to make this work but there's a weird interaction between make and docker that makes it lock up in the middle of a build in these containers with enough frequency for it to be a problem and make this impractical.