use with for json modules instead of assert#675
Merged
HarelM merged 2 commits intomaplibre:mainfrom May 20, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 104 104
Lines 4624 4624
Branches 1303 1303
=======================================
Hits 4275 4275
Misses 349 349 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Can you add a changelog item please? |
HarelM
approved these changes
May 20, 2024
HarelM
approved these changes
May 20, 2024
Collaborator
|
THANKS! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See maplibre/maplibre-gl-js#4092