use with for json modules instead of assert#4092
Merged
birkskyum merged 1 commit intomaplibre:mainfrom May 8, 2024
Merged
Conversation
birkskyum
changed the title
with for json modules instead of assert
Collaborator
|
Does it require a newer node version? Does it create any rollup issue? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4092 +/- ##
==========================================
- Coverage 86.61% 86.34% -0.28%
==========================================
Files 241 241
Lines 32518 32518
Branches 2145 2008 -137
==========================================
- Hits 28165 28077 -88
- Misses 3395 3476 +81
- Partials 958 965 +7 ☔ View full report in Codecov by Sentry. |
HarelM
approved these changes
May 8, 2024
Member
Author
|
I believe it works because the |
jleedev
added a commit
to jleedev/maplibre-style-spec
that referenced
this pull request
May 20, 2024
HarelM
pushed a commit
to maplibre/maplibre-style-spec
that referenced
this pull request
May 20, 2024
* use `with` for json modules instead of `assert` See maplibre/maplibre-gl-js#4092 * Add a changelog entry
ToHold
pushed a commit
to ToHold/maplibre-gl-js
that referenced
this pull request
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON modules / import attribute syntax has been changed from
asserttowith, which it appear to finally stabilize on.https://github.com/tc39/proposal-json-modules
https://github.com/tc39/proposal-import-attributes/