Skip to content

[WIP] Call instrument tests#29

Merged
regynald merged 13 commits intofeat/hardhat-coveragefrom
regynald/call-instrument-tests
May 24, 2022
Merged

[WIP] Call instrument tests#29
regynald merged 13 commits intofeat/hardhat-coveragefrom
regynald/call-instrument-tests

Conversation

@regynald
Copy link
Contributor

@regynald regynald commented May 23, 2022 •
edited
Loading

File % Stmts % Branch % Funcs % Lines Uncovered Lines
src/ 80.66 67.59 83 80.36
HookCoveredCall.sol 100 100 100 100
HookCoveredCallBeacon.sol 100 100 100 100
HookCoveredCallFactory.sol 100 50 100 100
HookCoveredCallImplV1.sol 72.41 61.84 68 72.27 ... 629,639,640
HookERC721MultiVault.sol 100 100 100 100
HookERC721MultiVaultBeacon.sol 100 100 100 100
HookERC721MultiVaultImplV1.sol 84.72 69.23 91.67 84.72 ... 451,452,453
HookERC721Vault.sol 100 100 100 100
HookERC721VaultBeacon.sol 100 100 100 100
HookERC721VaultFactory.sol 100 100 100 100
HookERC721VaultImplV1.sol 86.59 76.56 92 86.59 ... 454,461,462
HookProtocol.sol 73.08 16.67 66.67 74.07 ... 86,87,88,99
HookUpgradeableBeacon.sol 66.67 25 60 60 45,49,66,67
src/interfaces/ 100 100 100 100
IERC721FlashLoanReceiver.sol 100 100 100 100
IHookCoveredCall.sol 100 100 100 100
IHookCoveredCallFactory.sol 100 100 100 100
IHookERC721Vault.sol 100 100 100 100
IHookERC721VaultFactory.sol 100 100 100 100
IHookProtocol.sol 100 100 100 100
IHookVault.sol 100 100 100 100
IWETH.sol 100 100 100 100
src/lib/ 100 50 100 100
Entitlements.sol 100 100 100 100
Signatures.sol 100 50 100 100
src/mixin/ 100 100 100 100
EIP712.sol 100 100 100 100
PermissionConstants.sol 100 100 100 100
All files 81.01 67.43 83.65 80.81

This was referenced May 23, 2022
Merged
Merged
@regynald regynald force-pushed the regynald/call-instrument-tests branch from 72352cb to 7facbba Compare May 24, 2022 08:14
@regynald regynald changed the base branch from feat/hardhat-coverage to 05-23-vault_coverage_tests May 24, 2022 08:16
@regynald regynald force-pushed the regynald/call-instrument-tests branch from 1080e56 to fb04b37 Compare May 24, 2022 15:15
@regynald regynald changed the base branch from 05-23-vault_coverage_tests to feat/hardhat-coverage May 24, 2022 15:15
jake-nyquist
jake-nyquist reviewed May 24, 2022
View reviewed changes
integration/call-instrument.ts Outdated
1000,
expiration
);
// TODO: Find revert reason
Copy link
Contributor

@jake-nyquist jake-nyquist May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done

@regynald regynald marked this pull request as ready for review May 24, 2022 16:38
@regynald regynald merged commit 12d70e9 into feat/hardhat-coverage May 24, 2022
@regynald regynald deleted the regynald/call-instrument-tests branch May 24, 2022 16:41
jake-nyquist added a commit that referenced this pull request May 24, 2022
@regynald @jake-nyquist
[WIP] Call instrument tests (#29)
af3ea43 
* vault coverage tests

* 100% vault factory coverage

* empty case

* transfers

* Adding js helpers for singing Entitlement

* chainId for hardhat network

* up to 68% test coverage

* 85% coverage

* checkpoint

* 100% lines coverage in vaults

* Update gitignore

WIP tests

Working mintwitherc721 tests

Use before each

Most mintWithVault and mintWithEntitledVault tests

mintWithEntitledVault coverage

bid coverage

settle coverage

First reclaim test

* move tests into a single file

* add write with signature test (failing)

Co-authored-by: Jacob R. Nyquist <jake@nyqu.ist>
Co-authored-by: Eliecer Chicott <eliecerchicott@Eliecers-MacBook-Pro-2.local>
jake-nyquist added a commit that referenced this pull request May 26, 2022
@jake-nyquist @regynald
Hardhat code coverage tests (#27)
9d046f6 
* Add boilerplate hardhat implementation

* proto commit

* vault coverage tests (#28)

* vault coverage tests

* 100% vault factory coverage

* empty case

* transfers

* Adding js helpers for singing Entitlement

* chainId for hardhat network

* up to 68% test coverage

* 85% coverage

* checkpoint

* 100% lines coverage in vaults

Co-authored-by: Eliecer Chicott <eliecerchicott@Eliecers-MacBook-Pro-2.local>

* [WIP] Call instrument tests (#29)

* vault coverage tests

* 100% vault factory coverage

* empty case

* transfers

* Adding js helpers for singing Entitlement

* chainId for hardhat network

* up to 68% test coverage

* 85% coverage

* checkpoint

* 100% lines coverage in vaults

* Update gitignore

WIP tests

Working mintwitherc721 tests

Use before each

Most mintWithVault and mintWithEntitledVault tests

mintWithEntitledVault coverage

bid coverage

settle coverage

First reclaim test

* move tests into a single file

* add write with signature test (failing)

Co-authored-by: Jacob R. Nyquist <jake@nyqu.ist>
Co-authored-by: Eliecer Chicott <eliecerchicott@Eliecers-MacBook-Pro-2.local>

* tweak BeaconSalts to be an internal library, rename state variables

* Simplify reclaim asset (#31)

* Simplify reclaim asset logic

* Remaining reclaim tests

* call instrument config coverage

* getter coverage

* settle option and return nft coverage

* Fix rebase issue

* Fix test error

* protocol coverage (#32)

* spellcheck (#33)

* protocol coverage

* spellcheck

* Add more option events (#34)

* Add option settled event

* Remove console log tests

* Add callsettled and callreclaimed events; burnexpiredotion function

* burned expired option and coverage

* Fix issue with _allowedVaultImplementation

* Add solo vault test

* mintWithErc721 while multivault exists coverage

* burned expired option can't work on options with bids

* covered call reclaim forge tests working again

* all forge test working

* Fix slither gh action (#36)

* Update coverage.yml

* Update slither.yml

* Fix slither tag

* gas savings, entitlement simplification; (#37)

* Do not use structs on impose entitlement (#38)

* change impose to skip structs

* increase gas savings

* address pr comments

* fix build bug

* no warnings

* extra hardhat file cleanup

* expand gas limit

Co-authored-by: Eliecer Chicott <eliecerchicott@Eliecers-MacBook-Pro-2.local>
Co-authored-by: Regynald Augustin <github@regynald.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jake-nyquist jake-nyquist jake-nyquist approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@regynald @jake-nyquist