Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Merged
jake-nyquist
commented
May 24, 2022
jake-nyquist
changed the title
* vault coverage tests * 100% vault factory coverage * empty case * transfers * Adding js helpers for singing Entitlement * chainId for hardhat network * up to 68% test coverage * 85% coverage * checkpoint * 100% lines coverage in vaults Co-authored-by: Eliecer Chicott <eliecerchicott@Eliecers-MacBook-Pro-2.local>
* vault coverage tests * 100% vault factory coverage * empty case * transfers * Adding js helpers for singing Entitlement * chainId for hardhat network * up to 68% test coverage * 85% coverage * checkpoint * 100% lines coverage in vaults * Update gitignore WIP tests Working mintwitherc721 tests Use before each Most mintWithVault and mintWithEntitledVault tests mintWithEntitledVault coverage bid coverage settle coverage First reclaim test * move tests into a single file * add write with signature test (failing) Co-authored-by: Jacob R. Nyquist <jake@nyqu.ist> Co-authored-by: Eliecer Chicott <eliecerchicott@Eliecers-MacBook-Pro-2.local>
jake-nyquist
force-pushed
the
feat/hardhat-coverage
branch
from
12d70e9 to
cd46af8
Compare
* Simplify reclaim asset logic * Remaining reclaim tests * call instrument config coverage * getter coverage * settle option and return nft coverage * Fix rebase issue * Fix test error
* protocol coverage * spellcheck
* Add option settled event * Remove console log tests * Add callsettled and callreclaimed events; burnexpiredotion function * burned expired option and coverage * Fix issue with _allowedVaultImplementation * Add solo vault test * mintWithErc721 while multivault exists coverage * burned expired option can't work on options with bids * covered call reclaim forge tests working again * all forge test working
* Update coverage.yml * Update slither.yml * Fix slither tag
* change impose to skip structs * increase gas savings * address pr comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.