Skip to content

Fix runAndroid command#12402

Closed
SandroMachado wants to merge 1 commit intofacebook:masterfrom
uphold-forks:bugfix/run-android
Closed

Fix runAndroid command#12402
SandroMachado wants to merge 1 commit intofacebook:masterfrom
uphold-forks:bugfix/run-android

Conversation

@SandroMachado
Copy link
Contributor

The runAndroid command in the version 0.41 of the React Native has several issues. This PR fixes them.

With 0.41 the --configuration flag was removed from the runAndroid command. It was removed probably due to a bad rebase here. More information can be found in this PR.

Specifying the device id, with the flag --deviceId also bypass all the other configurations. For instance, if a flavor/variant is specified with the flags --flavor or --variant and a device id is also included with the flag --deviceId the flavor/variant is completely ignored.

I also included minor tweaks like always assemble the apkand only install it in a separated step.

With this PR, a command like react-native run-android --configuration release will generate an android apk with the release configuration, like in the version 0.40 of React Native.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 15, 2017
@AlanFoster
Copy link
Contributor

I think #12698 deals with this by updating the documentation

@evilDave
Copy link

Is this going to get merged soon? I'm talking about the fact that --variant will get ignored if you specify --deviceId.

@facebook-github-bot
Copy link
Contributor

@SandroMachado I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@stale
Copy link

stale bot commented Oct 13, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 13, 2017
@stale stale bot closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale There has been a lack of activity on this issue and it may be closed soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants