Conversation
|
I think #12698 deals with this by updating the documentation |
|
Is this going to get merged soon? I'm talking about the fact that --variant will get ignored if you specify --deviceId. |
|
@SandroMachado I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
The
runAndroidcommand in the version 0.41 of the React Native has several issues. This PR fixes them.With 0.41 the
--configurationflag was removed from therunAndroidcommand. It was removed probably due to a bad rebase here. More information can be found in this PR.Specifying the device id, with the flag
--deviceIdalso bypass all the other configurations. For instance, if aflavor/variantis specified with the flags--flavoror--variantand adevice idis also included with the flag--deviceIdtheflavor/variantis completely ignored.I also included minor tweaks like always assemble the
apkand only install it in a separated step.With this PR, a command like
react-native run-android --configuration releasewill generate an androidapkwith the release configuration, like in the version0.40of React Native.