Improve the Android release documentation

[SandroMachado]

The current documentation for the Android platform for the release process is outdated. This PR fixes the documentation.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @yutin1987 and @hramos to be potential reviewers.

[lacker]

@grabbou would you mind reviewing this?

[grabbou]

Not sure if this is grammatically correct, that the **release** apk``, shouldn't be that will generate the release apk?

[grabbou]

Also, I believe it's installed onto, not into.

[SandroMachado]

@grabbou update! Thanks for the review.

[grabbou]

BTW where is the configuration flag coming from? In the run-android docs I can still see the variant.

[SandroMachado]

@grabbou this commit destroyed the configuration flag and hardcoded the installDebug, the new feature introduced in 0.39. This is a regression.... Can this commit be removed? Being able to generate release builds from terminal is very useful.

Adding the flag --deviceIdFromList should not remove the --configuration flag....

BTW, since the configuration flag was removed by that commit.... this PR is useless right now. IMO, we should keep the configuration flag and keep this PR.

Probably it was a bad rebase, since the PR was created in August: #9568

Please keep the --configuration flag, I am already using it, and as you can see in the #10867, #11571 ... there are also other developers using it.

[shawngustaw]

Just wanted to chime in that it'd be helpful if this got merged :)

[jpshelley]

It seems configuration works great in React Native 0.40.0 (current stable) and variant doesn't as described in the issue, but in 0.41.0-rc.0 variant works as it should again and configuration doesn't.
Should probably just stick with one so as not to confuse future versions.

edit
Also, using 0.41.0-rc.0 there is a regression in regards to proguard. Check out #11891

[SandroMachado]

@grabbou sorry to bother you again. Can you please take a look to this PR and to the regressions described here?

[facebook-github-bot]

Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this.

[SandroMachado]

@hramos can you please take a look at my concerns described here: #11443 (comment)?

[hramos]

Sorry I missed that - from what I can see, this does not prevent the PR from being merged. Should we open a new issue to track this?

[SandroMachado]

The problem is that the feature I am documenting is on 0.40 and 0.39 but it is not in master (and in 0.41 beta). It was removed (I think, by mistake or in a bad rebase) by this commit: 85c8333

My suggestion is to remove this commit: 85c8333 rebase the PR with that commit and merge it again, but this time, without removing the configuration flag.

I think the configuration flag should not be removed. There are a lot of developers already using it like I said in my previous comment.

[SandroMachado]

@hramos and @grabbou with 0.41.X release the --configuration for android was removed by the bad merge I am talking above.

I can make a PR reintroducing the flag. WDYT?

[SandroMachado]

@grabbou and @hramos sorry to bother you again.

I decided to fix the issues I am talking above in another PR.

I will close this PR, since it is deprecated by #12402.