update progressCell for bolus display#2295
Merged
marionbarker merged 1 commit intodevfrom Mar 21, 2025
Merged
Conversation
Contributor
Author
|
Apologies - I rushed this through without testing properly. The original patch that @itsmojo gave me, did work for dev. But I had to modify it to make it work for tidepool-merge branch. I had forgotten this. FYI - @ps2:
Linking the PR to keep track:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
This PR fixes an intermittent bolus progress display error reported in these issues
@itsmojo identified root cause for this intermittent display error and passed on a proposed fix for the
mainbranch which is found in PR 2264.This PR is one of 3. One each to main (closed without merging), tidepool-merge (PR #2263) and dev (this one).
I was incorrect in this next statement.
They all have the same fix which has been tested extensively.The code change for tidepool-merge is different from that needed for main and dev and I mistakenly copied the tidepool-merge changes over. See #2298 for the correction needed for the dev branch.