update progressCell for bolus display for tidepool-merge#2263
Merged
marionbarker merged 1 commit intoLoopKit:tidepool-mergefrom Mar 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
This PR fixes an intermittent bolus progress display error reported in these issues
@itsmojo identified root cause for this intermittent display error and passed on a proposed fix for the
mainbranch.I tested the
tidepool-mergebuild using this test method and showed the intermittent display error occurs withtidepool-mergeas well asmain. The fix from @itsmojo was modified to work with the newtidepool-mergeversion of theLoop/View Controllers/StatusTableViewController.swiftfile.Test
This PR was applied to
tidepool-merge. The same test method mentioned above was used and every instance of opening the app in the middle of a bolus showed the correct value for the total bolus units.