Skip to content

fix(helm/dependabot/renovate): Fix broken automatic update#13613

Merged
valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom
kiblik:fix_13520
Nov 6, 2025
Merged

fix(helm/dependabot/renovate): Fix broken automatic update#13613
valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom
kiblik:fix_13520

Conversation

@kiblik
Copy link
Contributor

@kiblik kiblik commented Nov 4, 2025

Finish #13520
Fix #13530 & #13612
GHA is failing because action wasn't initialized correctly (https://github.com/DefectDojo/django-DefectDojo/actions/runs/19070470968/job/54486644356#step:4:21) - it needs to be checked out on the branch.

@dryrunsecurity
Copy link

dryrunsecurity bot commented Nov 4, 2025

DryRun Security

This pull request contains a workflow that checks out and runs code from the pull request head (github.event.pull_request.head.repo/full_name and ref), allowing untrusted forked PRs to execute arbitrary code in the CI environment and potentially exfiltrate GITHUB_TOKEN or other secrets. This is a high-risk workflow pattern and should be changed to avoid running untrusted code from forks, for example by restricting actions, using pull_request_target carefully, or requiring maintainer-reviewed workflows.

Arbitrary Code Execution in GitHub Actions from Forked Repository in .github/workflows/test-helm-chart.yml
Vulnerability Arbitrary Code Execution in GitHub Actions from Forked Repository
Description The GitHub Actions workflow uses actions/checkout to retrieve code from github.event.pull_request.head.repo.full_name and github.event.pull_request.head.ref. This means the workflow checks out and executes code directly from the head of a pull request, which can originate from an untrusted forked repository. An attacker can submit a pull request with malicious code, which will then be executed within the workflow's context, potentially leading to exfiltration of the GITHUB_TOKEN or other secrets, or injection of malicious artifacts.

with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten valentijnscholten added this to the 2.52.1 milestone Nov 4, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro requested a review from rossops November 5, 2025 19:06
@Maffooch Maffooch requested a review from Jino-T November 6, 2025 07:31
@valentijnscholten valentijnscholten merged commit 66b7334 into DefectDojo:bugfix Nov 6, 2025
150 checks passed
@kiblik kiblik deleted the fix_13520 branch November 6, 2025 19:20
Maffooch pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants