fix(HELM): Add "artifacthub.io/changes" for renovate & dependabot#13520
fix(HELM): Add "artifacthub.io/changes" for renovate & dependabot#13520valentijnscholten merged 1 commit intoDefectDojo:bugfixfrom
Conversation
|
This pull request contains a command injection vulnerability in the GitHub Actions workflow (.github/workflows/test-helm-chart.yml) where github.event.pull_request.title is interpolated into a shell run step and a malicious PR title with a single quote can break out of the quoted string to execute arbitrary commands on the runner; the existing if-condition does not reliably mitigate this because an attacker can craft a branch name from a fork to meet it. Fix by properly sanitizing or avoiding direct shell interpolation (use safe inputs, environment variables, or GitHub Actions toolkit commands).
Command Injection in GitHub Actions in
|
| Vulnerability | Command Injection in GitHub Actions |
|---|---|
| Description | The GitHub Actions workflow directly interpolates github.event.pull_request.title into a shell command within a run step. Although the string is single-quoted, a malicious pull request title containing a single quote character (') can break out of the quoted string, allowing an attacker to inject and execute arbitrary shell commands on the GitHub Actions runner. The if condition does not prevent exploitation, as an attacker can create a PR from a forked repository with a branch name matching the condition (e.g., renovate/malicious-branch). |
django-DefectDojo/.github/workflows/test-helm-chart.yml
Lines 106 to 109 in f984d64
All finding details can be found in the DryRun Security Dashboard.
…o#13520, DefectDojo#13530, DefectDojo#13612) Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
…o#13520, DefectDojo#13530, DefectDojo#13612) Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
…o#13520, DefectDojo#13530, DefectDojo#13612) Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
…o#13520, DefectDojo#13530, DefectDojo#13612) Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
…o#13520, DefectDojo#13530, DefectDojo#13612) (DefectDojo#13613) Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
.annotations."artifacthub.io/changes"inhelm/defectdojo/Chart.yamlwith the same text as the title of the related PR.