fix(prometheus): filter unregistered tag labels to prevent metric update errors#1
Merged
xfactor-toml merged 2 commits intomasterfrom Jan 28, 2026
Merged
Conversation
…ate errors Tags created after server startup were causing Prometheus metric update errors because they weren't included in the initial labelset registered during init(). This fix: - Adds a static Set to track tag labels registered at init time - Filters out unregistered tags in mapTagsToLabels() before they reach prom-client - Logs a warning message once per tag (not on every heartbeat) guiding users to restart the server for new tags to appear in Prometheus metrics This aligns with the existing documented behavior that new tags require a restart, but now handles it gracefully instead of throwing errors on every heartbeat. Fixes louislam#6728
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags created after server startup were causing Prometheus metric update errors because they weren't included in the initial labelset registered during init().
This fix:
This aligns with the existing documented behavior that new tags require a restart, but now handles it gracefully instead of throwing errors on every heartbeat.
Fixes louislam#6728