feat(eps-now): add 3 scenes for GLEDOPTO ESP-NOW WLED Remote Control#5400
feat(eps-now): add 3 scenes for GLEDOPTO ESP-NOW WLED Remote Control#5400
Conversation
This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control. Product link: https://www.amazon.com/dp/B0G7YZ5VJQ
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded three WizMote button definitions and handlers in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wled00/remote.cpp
Outdated
| case WIZMOTE_BUTTON_TWO : presetWithFallback(2, FX_MODE_BREATH, 0); break; | ||
| case WIZMOTE_BUTTON_THREE : presetWithFallback(3, FX_MODE_FIRE_FLICKER, 0); break; | ||
| case WIZMOTE_BUTTON_FOUR : presetWithFallback(4, FX_MODE_RAINBOW, 0); break; | ||
| case WIZMOTE_BUTTON_FIVE : presetWithFallback(5, FX_MODE_SCAN, 0); break; |
There was a problem hiding this comment.
better use a single led compatible FX as a fallback. like fireflicker
There was a problem hiding this comment.
why did you fix it and then unfix it?
There was a problem hiding this comment.
why did you fix it and then unfix it?
The fireflicker effect is already working. The code is:
case WIZMOTE_BUTTON_THREE : presetWithFallback(3, FX_MODE_FIRE_FLICKER, 0); break;
There was a problem hiding this comment.
good point, but my comment was about support for non-strip setups to have a fallback that works.
There was a problem hiding this comment.
good point, but my comment was about support for non-strip setups to have a fallback that works.
Okay, I understand what you mean.
I think the following effects also work well on a single LED, for example:
1. Color change effects:
- FX_MODE_RAINBOW
- FX_MODE_TRICOLOR_FADE
- FX_MODE_COLORWAVES
2. Brightness change effects:
- FX_MODE_BREATH
- FX_MODE_STROBE/FX_MODE_MULTI_STROBE
3. Random blinking effects:
- FX_MODE_COLORTWINKLE
However, users usually reset these presets, so I don't think what's set here is very important. Perhaps setting it back to FX_MODE_FIRE_FLICKER? Do you have any better suggestions? Thank you!
There was a problem hiding this comment.
users will very likely test the remote before setting up presets, if a fallback fails it will default to "static". The FX with single pixel support can be filtered in the FX list, the default should not be a too aggressive one like strobe (blink is also not really a good choice). Can you check for other FX that have single pixel support and replace blink and dissolve? I think candle may be one candidate.
There was a problem hiding this comment.
users will very likely test the remote before setting up presets, if a fallback fails it will default to "static". The FX with single pixel support can be filtered in the FX list, the default should not be a too aggressive one like strobe (blink is also not really a good choice). Can you check for other FX that have single pixel support and replace blink and dissolve? I think candle may be one candidate.
Thank you for the feedback! Based on your requirements for gentle, single-LED compatible effects, I've updated the fallbacks:
- BUTTON_FIVE: FX_MODE_SCAN → FX_MODE_CANDLE (as you suggested)
- BUTTON_SIX: FX_MODE_BLINK → FX_MODE_RANDOM_COLOR (smooth color transitions)
- BUTTON_SEVEN: Keep FX_MODE_FADE (already gentle and works well)
What do you think?
This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control. Product link: https://gledopto.com/h-pd-146.html
This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control. Product link: https://gledopto.com/h-pd-146.html
This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control.
Product link: https://gledopto.com/h-pd-146.html
Summary by CodeRabbit