Skip to content

feat(eps-now): add 3 scenes for GLEDOPTO ESP-NOW WLED Remote Control#5400

Open
GLEDOPTO wants to merge 3 commits intowled:mainfrom
GLEDOPTO:main
Open

feat(eps-now): add 3 scenes for GLEDOPTO ESP-NOW WLED Remote Control#5400
GLEDOPTO wants to merge 3 commits intowled:mainfrom
GLEDOPTO:main

Conversation

@GLEDOPTO
Copy link

@GLEDOPTO GLEDOPTO commented Feb 27, 2026

This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control.

Product link: https://gledopto.com/h-pd-146.html

Summary by CodeRabbit

  • New Features
    • Added support for three new WizMote remote buttons (5, 6, 7) to provide one-press access to Dissolve, Blink, and Fade lighting presets for faster mode changes.

This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control.

Product link: https://www.amazon.com/dp/B0G7YZ5VJQ
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92fb0eb and fa13a7c.

📒 Files selected for processing (1)
  • wled00/remote.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
  • wled00/remote.cpp

Walkthrough

Added three WizMote button definitions and handlers in wled00/remote.cpp for buttons FIVE, SIX, SEVEN. Each triggers presetWithFallback(..., palette=0, presetId=5/6/7) and maps to effect modes FX_MODE_DISSOLVE, FX_MODE_BLINK, and FX_MODE_FADE respectively.

Changes

Cohort / File(s) Summary
WizMote button additions
wled00/remote.cpp
Added macros WIZMOTE_BUTTON_FIVE/SIX/SEVEN (20/21/22) and switch cases that call presetWithFallback with palette=0 and presetId=5, 6, 7, mapping to FX_MODE_DISSOLVE, FX_MODE_BLINK, FX_MODE_FADE respectively.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • softhack007
  • DedeHai
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title mentions 'eps-now' and '3 scenes' for a GLEDOPTO remote, but the actual changes add three button definitions (FIVE, SIX, SEVEN) mapped to preset effects, not scenes. The terminology mismatch and reference to 'eps-now' (potentially a typo for 'ESP-NOW') creates ambiguity about what was actually changed. Clarify whether the changes implement 'scenes' or 'buttons/presets' and verify the correct terminology (ESP-NOW vs eps-now) to accurately reflect the technical nature of the modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

case WIZMOTE_BUTTON_TWO : presetWithFallback(2, FX_MODE_BREATH, 0); break;
case WIZMOTE_BUTTON_THREE : presetWithFallback(3, FX_MODE_FIRE_FLICKER, 0); break;
case WIZMOTE_BUTTON_FOUR : presetWithFallback(4, FX_MODE_RAINBOW, 0); break;
case WIZMOTE_BUTTON_FIVE : presetWithFallback(5, FX_MODE_SCAN, 0); break;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use a single led compatible FX as a fallback. like fireflicker

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you fix it and then unfix it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you fix it and then unfix it?

The fireflicker effect is already working. The code is:
case WIZMOTE_BUTTON_THREE : presetWithFallback(3, FX_MODE_FIRE_FLICKER, 0); break;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, but my comment was about support for non-strip setups to have a fallback that works.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, but my comment was about support for non-strip setups to have a fallback that works.

Okay, I understand what you mean.
I think the following effects also work well on a single LED, for example:
1. Color change effects:

  • FX_MODE_RAINBOW
  • FX_MODE_TRICOLOR_FADE
  • FX_MODE_COLORWAVES

2. Brightness change effects:

  • FX_MODE_BREATH
  • FX_MODE_STROBE/FX_MODE_MULTI_STROBE

3. Random blinking effects:

  • FX_MODE_COLORTWINKLE

However, users usually reset these presets, so I don't think what's set here is very important. Perhaps setting it back to FX_MODE_FIRE_FLICKER? Do you have any better suggestions? Thank you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users will very likely test the remote before setting up presets, if a fallback fails it will default to "static". The FX with single pixel support can be filtered in the FX list, the default should not be a too aggressive one like strobe (blink is also not really a good choice). Can you check for other FX that have single pixel support and replace blink and dissolve? I think candle may be one candidate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users will very likely test the remote before setting up presets, if a fallback fails it will default to "static". The FX with single pixel support can be filtered in the FX list, the default should not be a too aggressive one like strobe (blink is also not really a good choice). Can you check for other FX that have single pixel support and replace blink and dissolve? I think candle may be one candidate.

Thank you for the feedback! Based on your requirements for gentle, single-LED compatible effects, I've updated the fallbacks:

  • BUTTON_FIVE: FX_MODE_SCAN → FX_MODE_CANDLE (as you suggested)
  • BUTTON_SIX: FX_MODE_BLINK → FX_MODE_RANDOM_COLOR (smooth color transitions)
  • BUTTON_SEVEN: Keep FX_MODE_FADE (already gentle and works well)

What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats a good choice

GLEDOPTO added 2 commits March 2, 2026 13:44
This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control.

Product link: https://gledopto.com/h-pd-146.html
This PR adds three new scenes to the EPS-NOW remote controller to support the GLEDOPTO ESP-NOW WLED Remote Control.

Product link: https://gledopto.com/h-pd-146.html
@GLEDOPTO GLEDOPTO requested a review from DedeHai March 2, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants