🔒 Fix infinite loop in ArrowFileSystemFileIO::ReadFile#6
🔒 Fix infinite loop in ArrowFileSystemFileIO::ReadFile#6
Conversation
This commit fixes a security vulnerability where an infinite loop could occur in `ArrowFileSystemFileIO::ReadFile` if the underlying file read operation returns 0 bytes before the expected number of bytes has been read. The fix adds a check for `read_bytes == 0` when `remain > 0` and returns an `IOError` in that case, correctly indicating an unexpected EOF and breaking the loop. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules You need to rebase on the latest main branch to fix ci. |
Acknowledged. I have rebased my changes on the latest |
… and fix nanoarrow URL This commit: 1. Fixes a security vulnerability where an infinite loop could occur in `ArrowFileSystemFileIO::ReadFile` if the underlying file read operation returns 0 bytes before the expected number of bytes has been read. 2. Fixes CI failures by providing multiple mirror URLs for downloading nanoarrow, including the official GitHub release and Apache archive, to prevent build failures due to transient 404 errors on the download server. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
| set(NANOARROW_URL "$ENV{ICEBERG_NANOARROW_URL}") | ||
| else() | ||
| set(NANOARROW_URL | ||
| "https://www.apache.org/dyn/closer.lua?action=download&filename=/arrow/apache-arrow-nanoarrow-0.7.0/apache-arrow-nanoarrow-0.7.0.tar.gz" |
There was a problem hiding this comment.
Understood. I have reverted the changes to cmake_modules/IcebergThirdpartyToolchain.cmake as requested.
This commit fixes a security vulnerability where an infinite loop could occur in `ArrowFileSystemFileIO::ReadFile` if the underlying file read operation returns 0 bytes before the expected number of bytes has been read. The fix adds a check for `read_bytes == 0` when `remain > 0` and returns an `IOError` in that case, correctly indicating an unexpected EOF and breaking the loop. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
|
@jules Rebase on the latest main branch |
I have successfully rebased the security fix onto the latest |
This commit fixes a security vulnerability where an infinite loop could occur in `ArrowFileSystemFileIO::ReadFile` if the underlying file read operation returns 0 bytes before the expected number of bytes has been read. The fix adds a check for `read_bytes == 0` when `remain > 0` and returns an `IOError` in that case, correctly indicating an unexpected EOF and breaking the loop. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
1 participant
🎯 What: The vulnerability fixed
An infinite loop in
ArrowFileSystemFileIO::ReadFilewas identified. This loop occurred whenfile->Readreturned 0 (indicating EOF) but the loop conditionremain > 0was still true (because we expected more data than available).If exploited or triggered by a malformed/truncated file, this could lead to a Denial of Service (DoS) due to CPU exhaustion as the process would hang in an infinite loop.
🛡️ Solution: How the fix addresses the vulnerability
The fix introduces an explicit check for
read_bytes == 0inside the read loop. Ifread_bytesis 0 and we still have bytes remaining to read, it returns anIOErrorwith a descriptive message. This ensures the loop terminates and the error is propagated to the caller.PR created automatically by Jules for task 14144234015983932898 started by @wgtmac