Add textureBindingViewDimension and compat limits#580
Merged
kainino0x merged 6 commits intowebgpu-native:mainfrom Mar 9, 2026
Merged
Add textureBindingViewDimension and compat limits#580kainino0x merged 6 commits intowebgpu-native:mainfrom
kainino0x merged 6 commits intowebgpu-native:mainfrom
Conversation
Contributor
Author
|
@kainino0x Please review |
beaufortfrancois
force-pushed
the
compat
branch
from
6d960cb to
4a25f7f
Compare
beaufortfrancois
changed the title
beaufortfrancois
force-pushed
the
compat
branch
from
4a25f7f to
6fb8407
Compare
Kangz
reviewed
Feb 13, 2026
kainino0x
reviewed
Feb 13, 2026
This was referenced Feb 13, 2026
Contributor
Author
kainino0x
added a commit
that referenced
this pull request
Feb 20, 2026
Replace the manually-maintained INIT test lines with autogenerated tests. Used a quick hack in perl (only tool I could find that could do this easily), it just finds all the INIT macros defined in the header and outputs a test for each one. It's checked into the repo (instead of generated during build) so that I don't have to deal with making it work on the Windows compile test. This should have caught some missing items in #580
kainino0x
added a commit
that referenced
this pull request
Feb 20, 2026
Contributor
Author
|
Are we good merging now? |
Collaborator
|
Need review on #584 first. cwfitzgerald will look at it tomorrow |
Collaborator
|
Up @cwfitzgerald please take a look. |
Collaborator
|
Sorry for the delay, I've approved #584. |
kainino0x
approved these changes
Mar 9, 2026
Collaborator
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
LGTM, this should be safe to merge, it just copies the standardized JS API except for the naming of the structs, which I think follows the conventions we've established.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #470