fix: Replace innerHTML with textContent to fix security scanner false positive#2
Draft
fix: Replace innerHTML with textContent to fix security scanner false positive#2
Conversation
…tive Co-authored-by: vicaya <11239+vicaya@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Workaround high severity security vulnerability in flowchart.html
fix: Replace innerHTML with textContent to fix security scanner false positive
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
Fixes CodeQL/GitHub Advanced Security false positive flagging
innerHTMLusage indemos/flowchart.htmlas a "high severity security vulnerability" (DOM text reinterpreted as HTML).📏 Design Decisions
The
changeTheme()function restores diagram source text that was originally captured viatextContent. Since this is plain text mermaid syntax (not HTML), usingtextContentfor restoration is semantically correct and eliminates the security warning.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.