Move resource ownership into utopia-php/di by ChiragAgg5k · Pull Request #220 · utopia-php/http

ChiragAgg5k · 2026-03-10T05:46:32Z

Summary

remove the public HTTP resource registration API and move resource ownership to Utopia\DI\Container
inject a DI container into Http and use it internally for request-scoped framework resources like request, response, route, error, and adapter-specific raw resources
update adapters, tests, and docs to register custom resources directly on the DI container instead of Http::setResource()
keep hook and route ->inject() semantics in HTTP, but delegate resolution and lifecycle cleanup to DI
restore the e2e test runtime to a PHP 8.2-compatible setup so this branch can be validated in Docker again

Bug Exposed By This PR

moving HTTP resource ownership to utopia-php/di also raised the effective runtime floor for the branch because the DI package uses PHP 8.2 syntax
the existing FPM/Swoole test images were still built around the older setup, so CI started failing before the HTTP behavior could actually be exercised
after fixing the container/runtime mismatch, the remaining failing test exposed a latent FPM bug in chunked responses: Response::chunk() was re-sending headers after body output had already started, which triggered Cannot modify header information warnings and corrupted the response body

Fixes Included

pin the PHPUnit dependency graph back to a PHP 8.2-compatible doctrine/instantiator line in the lockfile
switch the FPM test image to an actual PHP 8.2 FPM runtime and update the test startup scripts to use the official image layout
update response streaming so headers/cookies are only emitted once for chunked responses, fixing the FPM warning and preserving the expected Hello World! body

Verification

composer validate --strict
docker compose exec fpm vendor/bin/phpunit --configuration phpunit.xml
docker compose exec swoole vendor/bin/phpunit --configuration phpunit.xml

Notes

this intentionally breaks the old Http::setResource() / Http::getResource() usage in favor of explicit DI ownership
the chunked response failure was not caused by DI resolution itself; the DI migration forced the branch onto a runtime where the pre-existing FPM header-ordering bug became visible

coderabbitai · 2026-03-10T05:46:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ad74ba1-02c7-4e6a-9847-a29751604885

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/use-di-resource-container

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ChiragAgg5k · 2026-03-10T05:59:36Z

@coderabbitai review

coderabbitai · 2026-03-10T05:59:46Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot

Pull request overview

This PR migrates HTTP “resource” ownership out of utopia-php/http and into utopia-php/di by injecting a DI container into Http and using it for request-scoped resources and adapter-provided raw resources.

Changes:

Removed Http::setResource() / Http::getResource() and delegated resource resolution/cleanup to Utopia\DI\Container.
Updated FPM/Swoole adapters to pass adapter-specific raw resources into Http’s request lifecycle.
Updated tests and docs to register custom resources directly on the DI container, and bumped minimum PHP version to 8.2.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`src/Http/Http.php`	Introduces DI container integration for resource wiring, resolution, refresh/purge lifecycle, and removes legacy resource APIs.
`src/Http/Adapter/FPM/Server.php`	Passes adapter raw resources through the onRequest callback to be registered per request.
`src/Http/Adapter/Swoole/Server.php`	Same as FPM: provides raw Swoole request/response as request-scoped resources.
`tests/HttpTest.php`	Refactors tests to use the DI container for resource registration/resolution instead of `Http`.
`README.md`	Updates docs/examples to use the DI container and the new `Http` constructor signature.
`docs/Getting-Starting-Guide.md`	Attempts to update the getting-started snippet and PHP requirement.
`composer.json`	Adds `utopia-php/di` dependency, VCS repository entry, and raises PHP constraint to >=8.2.
`composer.lock`	Locks the new DI dependency and updates platform PHP to >=8.2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Http/Adapter/FPM/Server.php

src/Http/Adapter/Swoole/Server.php

composer.json

docs/Getting-Starting-Guide.md

src/Http/Http.php

tests/HttpTest.php

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T08:47:33Z

src/Http/Http.php

    public function __construct(Adapter $server, string $timezone)
    {
        \date_default_timezone_set($timezone);
        $this->files = new Files();
        $this->server = $server;
+        $this->container = new Container();
    }


Http's constructor still only accepts (Adapter $server, string $timezone) and always creates a new internal Container. This prevents consumers from registering application dependencies (and forces tests to use Closure::bind to access $container), and it contradicts the updated docs/README which show passing a container into the constructor. Consider adding an optional ?Container $container parameter (defaulting to a new instance) and assigning it to $this->container so resource ownership can actually be externalized as described in the PR.

Copilot · 2026-03-12T08:47:33Z

README.md

+$http = new Http(new Server(), 'America/New_York', $container);
 $http->start();


This example calls new Http(..., $container), but Http::__construct currently only accepts (Adapter $server, string $timezone) and will throw an argument count error. Either update Http to accept an injected container (as the docs suggest) or adjust this snippet to match the actual constructor signature.

Copilot · 2026-03-12T08:47:33Z

README.md

+$http = new Http(new Server(), 'America/New_York', $container);
 $http->start();


This snippet passes $container as a third argument to Http::__construct, but Http currently only accepts two constructor arguments. This will fail at runtime; please align the docs with the actual API (or update Http to accept the container).

Copilot · 2026-03-12T08:47:33Z

README.md

+$http = new Http(new Server('0.0.0.0', '80'), 'America/New_York', $container);
 $http->start();


This Swoole example constructs Http with a third $container argument, but Http::__construct currently only accepts two parameters. Either make the constructor accept an injected container or update the example to avoid passing one.

src/Http/Response.php

Use utopia-php/di for resource injection

d2db9f3

Move resource ownership into utopia-php/di

a586863

ChiragAgg5k changed the title ~~Use utopia-php/di for resource injection~~ Move resource ownership into utopia-php/di Mar 10, 2026

ChiragAgg5k requested a review from Copilot March 10, 2026 06:00

Copilot started reviewing on behalf of ChiragAgg5k March 10, 2026 06:01 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

src/Http/Adapter/FPM/Server.php Show resolved Hide resolved

src/Http/Adapter/Swoole/Server.php Show resolved Hide resolved

composer.json Show resolved Hide resolved

composer.json Outdated Show resolved Hide resolved

docs/Getting-Starting-Guide.md Outdated Show resolved Hide resolved

ChiragAgg5k added 3 commits March 10, 2026 11:48

Update DI branch dependency

0991a26

update getting started

bf94cd2

update

82d7481

loks0n reviewed Mar 11, 2026

View reviewed changes

src/Http/Http.php Outdated Show resolved Hide resolved

loks0n reviewed Mar 11, 2026

View reviewed changes

tests/HttpTest.php Show resolved Hide resolved

loks0n reviewed Mar 11, 2026

View reviewed changes

tests/HttpTest.php Show resolved Hide resolved

ChiragAgg5k added 10 commits March 12, 2026 10:37

update

7996ee1

update appwrite base version

890f2d3

update to use php 8.2

44b1028

fix: restore php 8.2 test runtime

5bc45e3

chore: use container scopes

a4c9cfd

remove utopia keyword

6240285

remove optional container in run

6fd0984

remove optional container in run

ec4c1ff

renaming

f1020e7

remove public getContainer

9616993

ChiragAgg5k requested a review from Copilot March 12, 2026 08:41

Copilot started reviewing on behalf of ChiragAgg5k March 12, 2026 08:41 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

		$http = new Http(new Server(), 'America/New_York', $container);
		$http->start();

		$http = new Http(new Server('0.0.0.0', '80'), 'America/New_York', $container);
		$http->start();

Conversation

ChiragAgg5k commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Bug Exposed By This PR

Fixes Included

Verification

Notes

Uh oh!

coderabbitai bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

ChiragAgg5k commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ChiragAgg5k commented Mar 10, 2026 •

edited

Loading

coderabbitai bot commented Mar 10, 2026 •

edited

Loading