Fix issue 2260: Try not to break custom Help cmds.#2261
Open
bbadour wants to merge 1 commit intourfave:mainfrom
Open
Fix issue 2260: Try not to break custom Help cmds.#2261bbadour wants to merge 1 commit intourfave:mainfrom
bbadour wants to merge 1 commit intourfave:mainfrom
Conversation
Expand the check for the default help command to look at more than just the name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the check for the default help command to look at more than just the name.
What type of PR is this?
What this PR does / why we need it:
Fixes breakage in applications with custom Help commands.
Which issue(s) this PR fixes:
Fixes #2260
Special notes for your reviewer:
This change is sort of a hacky kludge I used when bringing in the latest version to not break existing applications. I would be more than happy if the issue gets fixed some other way.
Testing
I ran the equivalent change against tests for applications with custom Help commands.
Release Notes