Skip to content

feat(*): Enrich FullNode command-line-options#6397

Merged
kuny0707 merged 1 commit intotronprotocol:release_v4.8.1from
halibobo1205:feat/command_opt
Aug 13, 2025
Merged

feat(*): Enrich FullNode command-line-options#6397
kuny0707 merged 1 commit intotronprotocol:release_v4.8.1from
halibobo1205:feat/command_opt

Conversation

@halibobo1205
Copy link
Contributor

@halibobo1205 halibobo1205 commented Jul 10, 2025

close #6218.

@kuny0707 kuny0707 moved this to In Review in java-tron Jul 11, 2025
@kuny0707 kuny0707 linked an issue Jul 11, 2025 that may be closed by this pull request
Enrich FullNode command-line-options #6218
Closed
@halibobo1205
Copy link
Contributor Author

halibobo1205 commented Jul 14, 2025

TODO: SolidityNode has been replaced by FullNode --solidity. CI testing scenarios(buildkite/interface-status-test-in-docker)need to be adapted accordingly.

Sunny6889
Sunny6889 reviewed Jul 15, 2025
View reviewed changes
Sunny6889
Sunny6889 reviewed Jul 15, 2025
View reviewed changes
framework/src/main/java/org/tron/program/SolidityNode.java
logger.error("Trust node is not set.");
return;
}
parameter.setSolidityNode(true);
Copy link
Contributor

@Sunny6889 Sunny6889 Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove this parameter.setSolidityNode(true); effect the respected http/rpc service start?

Copy link
Contributor

@Sunny6889 Sunny6889 Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you check all related sub-class not depend this value

Copy link
Contributor Author

@halibobo1205 halibobo1205 Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter.setSolidityNode(true) is replaced by --solidity.

Image

@Sunny6889
Copy link
Contributor

Sunny6889 commented Jul 15, 2025

I have a question:
In existing FullNode with config node.http.solidityEnable with default is true, HTTP API /walletsolidity/... will return solidity info. Same asnode.rpc.solidityEnable for RPC request with protocol.WalletSolidity.
It seems we don't need SolidityNode at all, it only confuses users. Thus I think we don't need to support SolidityNode related features.

@halibobo1205
Copy link
Contributor Author

halibobo1205 commented Jul 16, 2025

@Sunny6889 Java-tron's support for SolidityNode is still quite valuable, particularly for accelerating historical synchronization. By configuring trusted nodes, SolidityNode can skip the computationally expensive signature verification process, resulting in roughly a 33% reduction in synchronization time.

@Sunny6889
Copy link
Contributor

Sunny6889 commented Jul 16, 2025

@Sunny6889 Java-tron's support for SolidityNode is still quite valuable, particularly for accelerating historical synchronization. By configuring trusted nodes, SolidityNode can skip the computationally expensive signature verification process, resulting in roughly a 33% reduction in synchronization time.

@halibobo1205 For SolidityNode it only sync soliditied blocks? Could you share more about where the logic control it?

@halibobo1205 halibobo1205 changed the title feat(*): Consolidate SolidityNode into FullNode with --solidity feat(*): Enrich FullNode command-line-options Jul 17, 2025
@halibobo1205
feat(db): merge related tools into FullNode/Toolkit
21f98b4 
- `--solidity`: SolidityNode → FullNode
- `--keystore`: KeystoreFactory → FullNode
- `db convert`: DBConvert → Toolkit
@halibobo1205
Copy link
Contributor Author

halibobo1205 commented Aug 13, 2025

@Sunny6889 Java-tron's support for SolidityNode is still quite valuable, particularly for accelerating historical synchronization. By configuring trusted nodes, SolidityNode can skip the computationally expensive signature verification process, resulting in roughly a 33% reduction in synchronization time.

@halibobo1205 For SolidityNode it only sync soliditied blocks? Could you share more about where the logic control it?

@Sunny6889
image

@kuny0707 kuny0707 merged commit 9247853 into tronprotocol:release_v4.8.1 Aug 13, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in java-tron Aug 13, 2025
@halibobo1205 halibobo1205 mentioned this pull request Sep 16, 2025
Merged
@halibobo1205 halibobo1205 mentioned this pull request Sep 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuny0707 kuny0707 kuny0707 approved these changes

@lvs0075 lvs0075 lvs0075 approved these changes

+2 more reviewers

@Sunny6889 Sunny6889 Sunny6889 left review comments

@xxo1shine xxo1shine xxo1shine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@halibobo1205 halibobo1205

Labels

None yet

Projects

java-tron
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enrich FullNode command-line-options

5 participants

@halibobo1205 @Sunny6889 @kuny0707 @xxo1shine @lvs0075