fix(people): correct friends list API endpoint for target users#103
fix(people): correct friends list API endpoint for target users#103tr4nt0r merged 2 commits intotr4nt0r:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 88.34% 88.31% -0.03%
==========================================
Files 54 54
Lines 2857 2868 +11
==========================================
+ Hits 2524 2533 +9
- Misses 333 335 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tr4nt0r
left a comment
There was a problem hiding this comment.
Generally looks good to me, just the docstring should be updated. And the endpoint we are replacing is still needed, I think it is the only way to retrieve the own profile, or a single profile for the specified xuid. Would you like to add a new method, e.g. get_profile_by_xuid in a follow-up PR?
|
Thanks, I've updated the docstring for get_friends_by_xuid. Regarding the follow-up PR, I can implement that, but should I wait for the current fix to be merged into main before opening the follow-up or would you prefer me to open it against this branch now? |
tr4nt0r
left a comment
There was a problem hiding this comment.
Let me merge this first. Thanks for your help 👍🏼
The
get_friends_by_xuidmethod was incorrectly routing to/users/me/people/xuids({xuid})/which only checks the relationship between the authenticated user and the target, returning empty data (0 friends) if they aren't mutual friends.This fixes the URL path to
/users/xuid({xuid})/people/friends/as in Xbox Android app, correctly utilizing Xbox Live Contract v7 to fetch a target user's friends list.