Fix(rust-tokenizer): increase integer width when converting hex literals#4573
Merged
georgesittas merged 1 commit intomainfrom Jan 7, 2025
Merged
Fix(rust-tokenizer): increase integer width when converting hex literals#4573georgesittas merged 1 commit intomainfrom
georgesittas merged 1 commit intomainfrom
Conversation
georgesittas
force-pushed
the
jo/fix_rust_hex_string_conversion
branch
from
343f190 to
e4338c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4560
The issue here was that u64 can represent up to 18446744073709551615, whereas the given hex literal is greater than this value: 378935326159973281336632520865622722.