Manifest builder improvements

[pittst3r]

Motivation

I noticed a few things to clean up:

• Rollup wasn't properly excluding node_modules from watch
• The Bundler try/finally was not wrapping the code that needed it
• At the default log level, users see manifest build errors, but nothing when the build becomes successful
• There is a bug in fs.promises.truncate() that causes warnings fsPromises.truncate doesn't close fd. nodejs/node#34189

Approach

• Use a regex to exclude node_modules from rollup watch
• Use ensure() API instead of try/finally in Bundler
• Upgrade the log level of the successful manifest build notification
• Use ftruncate() instead of truncate() until the fix is released

[changeset-bot]

🦋 Changeset is good to go

Latest commit: 5e0adf7

We got this.

This PR includes changesets to release 2 packages

Name	Type
@bigtest/bundler	Patch
@bigtest/server	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

The preview packages of this pull request have been published.
Click on the following packages for instructions on how to install them:

@bigtest/agent

---

Install using the following command:

$ npm install @bigtest/agent@manifest

Or update your package.json file:

{
  "@bigtest/agent": "manifest"
}

---

@bigtest/atom

---

Install using the following command:

$ npm install @bigtest/atom@manifest

Or update your package.json file:

{
  "@bigtest/atom": "manifest"
}

---

@bigtest/bundler

---

Install using the following command:

$ npm install @bigtest/bundler@manifest

Or update your package.json file:

{
  "@bigtest/bundler": "manifest"
}

---

@bigtest/cli

---

Install using the following command:

$ npm install @bigtest/cli@manifest

Or update your package.json file:

{
  "@bigtest/cli": "manifest"
}

---

@bigtest/interactor

---

Install using the following command:

$ npm install @bigtest/interactor@manifest

Or update your package.json file:

{
  "@bigtest/interactor": "manifest"
}

---

@bigtest/server

---

Install using the following command:

$ npm install @bigtest/server@manifest

Or update your package.json file:

{
  "@bigtest/server": "manifest"
}

---

@bigtest/webdriver

---

Install using the following command:

$ npm install @bigtest/webdriver@manifest

Or update your package.json file:

{
  "@bigtest/webdriver": "manifest"
}

---

Generated by 🚫 dangerJS against 5e0adf7

[cowboyd]

Nice set of stability fixes! 🍷

[cowboyd]

I'm still not quite sure why a try/catch won't catch the right thing. If you put it around 82-90, it will catch any exception raised therein.

[pittst3r]

This is what it was originally:

let rollup: RollupWatcher = watch(prepareRollupOptions(bundles));;
let events: ChainableSubscription<Array<RollupWatcherEvent>, undefined> = yield subscribe(on<Array<RollupWatcherEvent>>(rollup, 'event'));
let messages = events
  .map(([event]) => event)
  .filter(event => event.code === 'END' || event.code === 'ERROR')
  .map(event => event.code === 'ERROR' ? { type: 'error', error: event.error } : { type: 'update' });

try {
  yield messages.forEach(function*(message) {
    bundler.channel.send(message as BundlerMessage);
  });
} finally {
  rollup.close();
}

Which is wrong I think, prompting me to make a change. However, rather than just wrap more in the try block I thought ensure() was the way to go, but now that you've explained that that's not the way to go I'll update to this:

let rollup: RollupWatcher = watch(prepareRollupOptions(bundles));;

try {
  let events: ChainableSubscription<Array<RollupWatcherEvent>, undefined> = yield subscribe(on<Array<RollupWatcherEvent>>(rollup, 'event'));
  let messages = events
    .map(([event]) => event)
    .filter(event => event.code === 'END' || event.code === 'ERROR')
    .map(event => event.code === 'ERROR' ? { type: 'error', error: event.error } : { type: 'update' });

  yield messages.forEach(function*(message) {
    bundler.channel.send(message as BundlerMessage);
  });
} finally {
  rollup.close();
}