Update to latest LocalStack container and support unified port mode#2825
Merged
rnorth merged 28 commits intotestcontainers:masterfrom Jul 19, 2020
artamonovkirill:chore/latest-localstack
Merged
Update to latest LocalStack container and support unified port mode#2825rnorth merged 28 commits intotestcontainers:masterfrom artamonovkirill:chore/latest-localstack
rnorth merged 28 commits intotestcontainers:masterfrom
artamonovkirill:chore/latest-localstack
Conversation
Contributor
artamonovkirill
commented
May 31, 2020
artamonovkirill
commented
- Latest LocalStack default container.
- Single port exposed and used for AWS endpoints.
7 tasks
rnorth
reviewed
Jun 5, 2020
...s/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java
Outdated
Show resolved
Hide resolved
rnorth
reviewed
Jun 5, 2020
...ck/src/test/java/org/testcontainers/containers/localstack/LocalstackLegacyContainerTest.java
Outdated
Show resolved
Hide resolved
…Container(String version, boolean legacyMode) constructor. Extended test cases.
…-constructors # Conflicts: # core/src/test/java/org/testcontainers/images/RemoteDockerImageTest.java # modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java # modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java # modules/pulsar/src/main/java/org/testcontainers/containers/PulsarContainer.java # modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java
|
Any status on this? The newest version of localstack (0.11.3) fixes localstack/localstack#1685, and we're running into a frustrating issue with some testcontainer-based tests (which are otherwise awesome!) because of that bug so would love to be able to use the latest localstack. |
Member
|
We have some changes coming in #2839 which deprecate default constructors, and will always encourage the user to specify an image, for all classes including Since the changes are not trivial, and this PR will be affected. I'll take an action to refactor this PR. |
Contributor
Author
|
@cwacekINV, I ended up writing a custom wrapper around a GenericContainer: |
Tweak some stylistic aspects of the code
Member
rnorth
changed the title
rnorth
changed the title
rnorth
changed the title
rnorth
approved these changes
Jul 19, 2020
Member
|
Merging - thansk @artamonovkirill! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.