Skip to content

Upgrade cockroachdb image tag to v20.1.0#2773

Closed
rpalcolea wants to merge 1 commit intotestcontainers:masterfrom
rpalcolea:upgrade-cockroachdb
Closed

Upgrade cockroachdb image tag to v20.1.0#2773
rpalcolea wants to merge 1 commit intotestcontainers:masterfrom
rpalcolea:upgrade-cockroachdb

Conversation

@rpalcolea
Copy link
Contributor

@rpalcolea rpalcolea commented May 20, 2020

Hi folks,

While doing some integration testing + flyway, I found that the image tag for cockroachdb in testcontainers is 19.1.1 because I faced cockroachdb/cockroach#28751 😅

I think it would be great if the latest stable release is used here which is v20.1.0 released on May 12th.

@rpalcolea rpalcolea changed the title Upgrade cockroachdb image tag go v20.1.0 Upgrade cockroachdb image tag to v20.1.0 May 20, 2020
@rnorth rnorth mentioned this pull request Jun 5, 2020
7 tasks
@rnorth
Copy link
Member

rnorth commented Jun 18, 2020

With #2839 we're intending to deprecate the default constructor for all modules and start encouraging all users to specify a version explicitly. This is primarily to avoid the risk of us breaking users' builds by changing the docker image unexpectedly.

As such, I'll close this PR, as I'd expect that we will leave default image tags where they are until they eventually get removed altogether.

@rnorth rnorth closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants