Fix IDE preview not showing for queued tool approvals#35
Merged
Conversation
- Execute approval-requiring tools sequentially, not in parallel - This prevents IDE previews from overwriting each other when multiple edit_file/write_file calls are queued - Pre-approved tools can still run in parallel - Also fix denied/error pipelines to run their finally handlers (e.g., IdeClosePreview) before being removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When multiple tool calls that require approval (e.g., edit_file) were queued, their pipelines all started executing immediately. This caused IDE previews to overwrite each other - when the user approved/denied the first tool, the next tool's approval would show but its preview was gone.
Solution
Execute approval-requiring tools sequentially instead of in parallel:
Also fixes denied/error pipelines to properly run their finally handlers (e.g.,
IdeClosePreview) before being removed from active pipelines.Testing
Tested by queuing multiple edit_file calls - each preview now appears correctly as the previous one is approved/denied.