Fix read file tool to respect start_line and end_line parameters#29
Merged
Fix read file tool to respect start_line and end_line parameters#29
Conversation
Two bugs were fixed: 1. The start_line and end_line parameters were parsed but never used - they were marked #[allow(dead_code)] and not passed to the handler 2. Even if line filtering was implemented, line numbers would show 1, 2, 3 instead of the actual file line numbers Changes: - Updated io::read_file() to accept optional start_line and end_line params - Updated ReadFile handler to pass line range parameters - Updated ReadFileTool::compose() to pass params from the parsed request - Added proper tests verifying both line filtering and correct numbering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs were fixed:
they were marked #[allow(dead_code)] and not passed to the handler
instead of the actual file line numbers
Changes: