fix: handle None text in message content sanitization#1920
Open
yoppi wants to merge 1 commit intostrands-agents:mainfrom
Open
fix: handle None text in message content sanitization#1920yoppi wants to merge 1 commit intostrands-agents:mainfrom
yoppi wants to merge 1 commit intostrands-agents:mainfrom
Conversation
`_normalize_messages` and `remove_blank_messages_content_text` call
`.strip()` on `item["text"]` without guarding against `None`. When a
model provider (e.g. Gemini) returns a content block with `{"text": None}`,
this causes `TypeError: expected string or bytes-like object, got 'NoneType'`.
Add explicit `None` checks before calling `.strip()`:
- With tool_use: None text items are removed (same as blank text)
- Without tool_use: None text is replaced with "[blank text]" (same as blank)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_normalize_messagesandremove_blank_messages_content_textcall.strip()onitem["text"]without guarding againstNone. When a model provider (e.g. Gemini) returns a content block with{"text": None}, this causesTypeError: expected string or bytes-like object, got 'NoneType'.Add explicit
Nonechecks before calling.strip():Related Issues
Documentation PR
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.