feat: rename tutorialkit to @tutorialkit/cli#153
Merged
AriPerkkio merged 3 commits intostackblitz:mainfrom Aug 6, 2024
Merged
Conversation
|
|
AriPerkkio
force-pushed
the
feat/rename-cli
branch
from
a27dbe0 to
055b157
Compare
Member
This package used to exist, I think we might have cleaned the alpha versions that we had published for testing. Hopefully that won't be a problem. |
Nemikolh
approved these changes
Jul 29, 2024
Member
Nemikolh
left a comment
Nemikolh
left a comment
There was a problem hiding this comment.
Looks good! Love the cleanup as well 🤗
Contributor
Author
|
I think this is actually not a breaking change as CLI packages are not installed by end-users. I'll resolve the conflicts and then we can merged this. |
Member
|
Yeah I agree, let's move forward with this PR 👍 |
Co-authored-by: Jòan <Nemikolh@users.noreply.github.com>
AriPerkkio
force-pushed
the
feat/rename-cli
branch
from
54931d7 to
fdc8f42
Compare
AriPerkkio
changed the title
tutorialkit to @tutorialkit/clitutorialkit to @tutorialkit/cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tutorialkitto@tutorialkit/cliCONTRIBUTING.mdabout package naming convention. This is mostly related to development time communication practices and doesn't affect end users.tutorialkit-vscodetotutorialkit. Removes work-around from build script that was used to do this renaming right before publishing. This name is already used by the published extension.BREAKING CHANGES:
tutorialkitnpm package is now unused. We should probably deprecate that from npm? Or just leave it as is.@tutorialkit/cli. This package does not yet exist in npm. I'm not sure if publishing this package will work without any permission settings. Do we need to add https://www.npmjs.com/~stackblitz-devops there some how?