Skip to content

Allow specifying additional extensions to load in Druid#547

Merged
labrenbe merged 17 commits intomainfrom
feat/additional-extensions
May 2, 2024
Merged

Allow specifying additional extensions to load in Druid#547
labrenbe merged 17 commits intomainfrom
feat/additional-extensions

Conversation

@labrenbe
Copy link
Member

@labrenbe labrenbe commented Apr 30, 2024

Description

Closes #490

Currently the only way to enable additional extensions is to use config overrides potentially removing extension that were added to the extension load based by the operator

This PR adds a field additionalExtensions to clusterConfig containing a simple list of extension names. Extra configuration required by additional extensions is not in scope of this PR.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [X] CRD changes approved
- [X] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@labrenbe labrenbe linked an issue Apr 30, 2024 that may be closed by this pull request
@sbernauer sbernauer self-requested a review April 30, 2024 12:28
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As talked offline I pushed the experiment to feat/additional-extensions-review.
We also created kube-rs/kube#1484

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

sbernauer
sbernauer previously approved these changes May 2, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@labrenbe labrenbe added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 4ee36b9 May 2, 2024
@labrenbe labrenbe deleted the feat/additional-extensions branch May 2, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improved extension handling

4 participants