feat: Add vendor label to deployed third-party resources#9
Merged
Conversation
Techassi
changed the title
Techassi
changed the title
adwk67
requested changes
Jan 30, 2024
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
I found a few places where values do not get "passed through" but I guess these are largely out of our control.
sbernauer
reviewed
Feb 1, 2024
demos/data-lakehouse-iceberg-trino-spark/create-spark-ingestion-job.yaml
Show resolved
Hide resolved
Member
Author
|
Removed all vendor labels from the demo/stack manifests as discussed in today's (2024-02-01) meeting. |
Techassi
changed the title
adwk67
approved these changes
Feb 1, 2024
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
lgtm. There are still some labels that do not get passed through but not much we can do about that: the main thing is that the errors are gone. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#188, part of stackabletech/stackable-cockpit#134