Update documentation code snippet to ensure feedback widget displays after instant navigation#8275
Merged
squidfunk merged 1 commit intosquidfunk:masterfrom Jun 23, 2025
Merged
Conversation
Owner
|
Thanks for the PR. Yes, that's definitely oversight, and the fix looks correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the feedback widget wouldn't display after instant navigation (see issue #4277). Although this was fixed, the documentation's example for implementing a custom feedback handler still results in this issue. Please double check my PR as I blindly replicated the fix from #4277. This worked for me but javascript is not my forte.