only instantiate get_spdx_licensing() once in the project#749
Merged
armintaenzertng merged 1 commit intospdx:mainfrom Aug 23, 2023
Merged
only instantiate get_spdx_licensing() once in the project#749armintaenzertng merged 1 commit intospdx:mainfrom
get_spdx_licensing() once in the project#749armintaenzertng merged 1 commit intospdx:mainfrom
Conversation
this getter takes quite some time and should be called as few times as possible Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
armintaenzertng
force-pushed
the
validation_performance
branch
from
9d74680 to
1c2aeb4
Compare
armintaenzertng
changed the title
get_spdx_licensing() once per moduleget_spdx_licensing() once in the project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #742, I noticed that calling
get_spdx_licensing()takes quite some time and should be done as few times as possible. I refactored the code so that a single licensing instance is shared over the whole project.