Issue 381 add tag value writer#395
Closed
meretp wants to merge 3 commits intospdx:refactor-python-toolsfrom
Closed
Issue 381 add tag value writer#395meretp wants to merge 3 commits intospdx:refactor-python-toolsfrom
meretp wants to merge 3 commits intospdx:refactor-python-toolsfrom
Conversation
added 2 commits
December 29, 2022 16:29
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
armintaenzertng
requested changes
Dec 30, 2022
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks for the effort! :)
Comment on lines
+48
to
+49
| def transform_enum_name_to_tv(enum_str: str) -> str: | ||
| return enum_str.replace("_", "-") |
Collaborator
There was a problem hiding this comment.
This should be extracted and merged with a similar function from the json writer
Collaborator
|
Work will continue in #396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes code from #379, so depending on which PR is merged first, there will probably be merge conflicts with the one or the other when rebasing.
I didn't manage to add tests, #394 is opened to keep track of this.