[file_selector] Migrate FileSelectorWindows to use FileSelectorApi Dart implementation#33
Closed
adpinola wants to merge 2 commits intofile_selector/windows/66584-migrate-FileSelectorApifrom
Conversation
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
39158c0 to
151e185
Compare
adpinola
force-pushed
the
file_selector/windows/66671-replace-file-selector-api-with-new-implementation
branch
from
4c72455 to
0110958
Compare
| } | ||
|
|
||
| List<TypeGroup> _typeGroupsFromXTypeGroups(List<XTypeGroup>? xtypes) { | ||
| List<XTypeGroup> _getValidFromXTypeGroups(List<XTypeGroup>? xtypes) { |
There was a problem hiding this comment.
maybe we can find a better name for this method
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
151e185 to
73ffb8e
Compare
adpinola
force-pushed
the
file_selector/windows/66671-replace-file-selector-api-with-new-implementation
branch
from
7171335 to
90ed9c4
Compare
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
73ffb8e to
9a1ca9a
Compare
adpinola
force-pushed
the
file_selector/windows/66671-replace-file-selector-api-with-new-implementation
branch
2 times, most recently
from
97f0f34 to
54b401c
Compare
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
9a1ca9a to
07f6dce
Compare
Remove the old implementation with C++. use dart implementation rename method
adpinola
force-pushed
the
file_selector/windows/66671-replace-file-selector-api-with-new-implementation
branch
from
bf96c82 to
e346432
Compare
Author
|
Closing this PR because it will be opened in main repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the changes in:
Issue: [file_selector_windows] Migrate CPP implementation to Dart. #112212
These changes finish the Migration from CPP to Dart.
The following images show the current functionality tested against the example app located at
file_selector_windows/exampleOpen File
Open Image
Open Multiple Images
Save a File
Get Directory Path
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.