Skip to content

Remove incorrect external tooltips for linter rules#175

Merged
jviotti merged 1 commit intomainfrom
no-external-tooltips
Mar 6, 2026
Merged

Remove incorrect external tooltips for linter rules#175
jviotti merged 1 commit intomainfrom
no-external-tooltips

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 6, 2026

See: #173
Fixes: #174
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

See: #173
Fixes: #174
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Mar 6, 2026

🤖 Augment PR Summary

Summary: This PR removes the external documentation link previously attached to lint diagnostic codes in the VS Code extension to avoid pointing users to incorrect third-party rule docs.

Changes:

  • Set lint diagnostic code to a plain rule-id string (no target URL)
  • Update/add VS Code extension tests to assert diagnostic codes are strings and remain link-free

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@jviotti jviotti merged commit 9450c62 into main Mar 6, 2026
5 checks passed
@jviotti jviotti deleted the no-external-tooltips branch March 6, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https://github.com/Karan-Palan/json-schema-lint-rules/tree/main/docs/top_level_examples.md does not lead anywhere.

1 participant