Improve e2e tests to check for a "ready" event emitted by the UI#117
Merged
Improve e2e tests to check for a "ready" event emitted by the UI#117
Conversation
jviotti
force-pushed
the
fix-broken-cli-path
branch
2 times, most recently
from
43c3d6a to
a75cf0e
Compare
🤖 Augment PR SummarySummary: Fixes the VS Code extension’s bundled CLI entrypoint so lint/format/metaschema commands run correctly (addresses #116).
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
jviotti
force-pushed
the
fix-broken-cli-path
branch
3 times, most recently
from
8eb9278 to
85a4f9d
Compare
jviotti
changed the title
Also extend the extension and the e2e test suite to better catch and report these issues that can lead to a non-working UI despite of a working extension in the background (which made the existing e2e suite pass). Fixes: #116 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
force-pushed
the
fix-broken-cli-path
branch
from
85a4f9d to
aa87eb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #116
Signed-off-by: Juan Cruz Viotti jv@jviotti.com