Skip to content

Simplify not checks on duration designator schemas#86

Merged
jviotti merged 1 commit intomainfrom
not-enum
Dec 22, 2025
Merged

Simplify not checks on duration designator schemas#86
jviotti merged 1 commit intomainfrom
not-enum

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Dec 21, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Dec 21, 2025

🤖 Augment PR Summary

Summary: Refactors the ISO 8601 duration “designator” schemas to consolidate disallowed bare designators.

Changes:

  • In designator.json, replaced multiple allOf + not + const checks with a single not + enum.
  • In designator-extension.json, applied the same simplification while also covering the negative variants.

Technical Notes: This should be behavior-preserving: the schema still rejects P/PT (and -P/-PT in the extension) while validating the allowed pattern-based duration formats.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit d3d571b into main Dec 22, 2025
2 checks passed
@jviotti jviotti deleted the not-enum branch December 22, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant