fix: add missing fields in ChannelCreatedEvent#2166
fix: add missing fields in ChannelCreatedEvent#2166WilliamBergamin merged 1 commit intoslackapi:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2166 +/- ##
=======================================
Coverage 82.07% 82.07%
=======================================
Files 18 18
Lines 1545 1545
Branches 443 443
=======================================
Hits 1268 1268
Misses 179 179
Partials 98 98 ☔ View full report in Codecov by Sentry. |
|
Thanks for the contribution @maxretries The following is the schema of the "payload": {
"token": "E1a2b3c",
"team_id": "T123",
"api_app_id": "A123",
"event": {
"type": "channel_created",
"channel": {
"id": "C123",
"name": "hello-this-is-a-test",
"is_channel": true,
"is_group": false,
"is_im": false,
"is_mpim": false,
"is_private": false,
"created": 1721054427,
"is_archived": false,
"is_general": false,
"unlinked": 0,
"name_normalized": "hello-this-is-a-test",
"is_shared": false,
"is_frozen": false,
"is_org_shared": false,
"is_pending_ext_shared": false,
"pending_shared": [],
"context_team_id": "T123",
"updated": 1721054427220,
"parent_conversation": null,
"creator": "U123",
"is_ext_shared": false,
"shared_team_ids": [
"T123"
],
"pending_connected_team_ids": [],
"topic": {
"value": "",
"creator": "",
"last_set": 0
},
"purpose": {
"value": "",
"creator": "",
"last_set": 0
},
"previous_names": []
},
"event_ts": "1721054427.004200"
},
"type": "event_callback",
"event_id": "E123",
"event_time": 1721054427,
"authorizations": [
{
"enterprise_id": null,
"team_id": "T123",
"user_id": "U123",
"is_bot": true,
"is_enterprise_install": false
}
],
"is_ext_shared_channel": false
}This aligns with the example payload found in the java payload as well |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for the contribution 💯
All these fields are valid 👍
is_archived, is_frozen, is_external_shared, is_pending_ext_shared and others should always be false on the channel_created event, since the channel is new. I don't think this object needs to include them but we can leave them in
|
Hi @WilliamBergamin thanks for merging this. These fields don't seem be be |
Summary
fixes #2165
Adds missing fields in
ChannelCreatedEventinterface.Requirements (place an
xin each[ ])