chore(monitoring): remove SSE connection tracking and Bun.gc debug instrumentation#3472
chore(monitoring): remove SSE connection tracking and Bun.gc debug instrumentation#3472waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Simplifies memory telemetry ( Written by Cursor Bugbot for commit 547aee3. Configure here. |
Greptile SummaryThis is a straightforward maintenance PR that removes temporary debug instrumentation added to diagnose a memory leak: it deletes Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[SSE Route Handler] --> B{Stream opens}
B -->|Before PR| C[incrementSSEConnections]
B -->|After PR| E[Start streaming directly]
C --> E
E --> F[Stream body executes]
F --> G{Stream ends}
G -->|finally / cancel| H[Before PR: decrementSSEConnections]
G -->|finally / cancel| I[After PR: cleanup only]
H --> J[sse-connections Map updated]
J --> K[memory-telemetry reads count every 60s]
I --> L[memory-telemetry logs heap stats only]
K -.->|removed| M[sse-connections.ts deleted]
L --> N[Production observability retained]
Last reviewed commit: 547aee3 |
547aee3 to
e0612af
Compare
Summary
sse-connections.tsand all increment/decrement calls across 5 SSE route handlers — was added purely to debug the memory leakBun.gc(false)call from memory telemetry — no longer needed after Bun 1.3.10 upgrade fixed the root causememory-telemetry.tsstripped down for ongoing production observabilityType of Change
Testing
Tested manually — lint passes (pre-existing biome config issue on main), no remaining references to removed code
Checklist