Refactored FuncDSL by renaming clazz to inputClass #1208
Merged
fjtirado merged 2 commits intoserverlessworkflow:mainfrom Mar 6, 2026
Merged
Refactored FuncDSL by renaming clazz to inputClass #1208fjtirado merged 2 commits intoserverlessworkflow:mainfrom
fjtirado merged 2 commits intoserverlessworkflow:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the fluent function DSL API to use a clearer parameter name (inputClass) instead of clazz for Class<T> type-hint parameters, improving readability for callers and generated documentation.
Changes:
- Renamed
clazz→inputClassacross multipleFuncDSLhelper methods and their Javadocs. - Updated local variable names where input type is inferred to match the new terminology.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mcruzdev
approved these changes
Mar 6, 2026
Collaborator
mcruzdev
left a comment
mcruzdev
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot for this pull request!
Collaborator
|
@amineis you need to sign your commit |
Signed-off-by: amineis <amineidrissis12@gmail.com>
Signed-off-by: amineis <amineidrissis12@gmail.com>
amineis
force-pushed
the
refactored-func-dsl
branch
from
16efc6b to
d7e27e3
Compare
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1199
Summary
Renamed the
clazzparameter toinputClassinFuncDSLto improve clarity and make the semantics ofinputFromandoutputAseasier to understand.Changes
clazzparameter toinputClassinFuncDSLChecklist
Note: The API module still has a test failure. This PR does not change the API module; that issue is separate.