change the exclusion pattern for bots#636
Merged
henryiii merged 8 commits intoscientific-python:mainfrom Aug 22, 2025
Merged
Conversation
It seems github changed the way this works, such that this has to match what is displayed as author (which includes the `[bot]` marker for bots like `pre-commit-ci` and `dependabot`)
keewis
commented
Aug 22, 2025
(and also to prevent the auto-formatter from removing the changes)
Collaborator
|
I've noticed this too. We should change our own, too. I think you lost the changes in your commit, though. |
Contributor
Author
|
yep, |
Collaborator
|
Ah, you need to change the template, cog makes this from the template. |
Contributor
Author
|
while we're at it, the link in that section appears to be broken (target |
Collaborator
|
Thanks! We could possibly even add a check for this in sp-repo-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems github changed the way the exclusion from auto-generated release notes works, such that this has to match what is displayed as author.
In other words, the only way I could get it to exclude the bots was to include the
[bot]suffix for bots likepre-commit-cianddependabot.(not sure if I did something wrong, though)
📚 Documentation preview 📚: https://scientific-python-cookie--636.org.readthedocs.build/