feat(k8s): add version commands#775
Merged
loicbourgois merged 8 commits intoscaleway:v2from Mar 17, 2020
Merged
Conversation
loicbourgois
suggested changes
Mar 17, 2020
Contributor
loicbourgois
left a comment
loicbourgois
left a comment
There was a problem hiding this comment.
Can you add tests please ?
At least :
- a simple ok test, that uses a golden, so we can check what the output looks like
- a test for each error, using
TestCheckError: here we're interested in the error, not how it is presented
loicbourgois
suggested changes
Mar 17, 2020
internal/namespaces/k8s/v1beta4/testdata/test-get-version-simple.stdout.golden
Show resolved
Hide resolved
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Co-Authored-By: Loïc Bourgois <loic@bourgois.pro>
Co-Authored-By: Loïc Bourgois <loic@bourgois.pro>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
clement-gilbert
pushed a commit
to clement-gilbert/scaleway-cli
that referenced
this pull request
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need the generated version commands first
Signed-off-by: Patrik Cyvoct pcyvoct@scaleway.com