Skip to content

chore: remove boolean without value in args#767

Merged
loicbourgois merged 5 commits intoscaleway:v2from
loicbourgois:APIGW-1901
Mar 12, 2020
Merged

chore: remove boolean without value in args#767
loicbourgois merged 5 commits intoscaleway:v2from
loicbourgois:APIGW-1901

Conversation

@loicbourgois
Copy link
Copy Markdown
Contributor

No description provided.

@loicbourgois loicbourgois changed the title wip: chore: remove boolean without value in args chore: remove boolean without value in args Mar 11, 2020
Copy link
Copy Markdown
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should return a CliError with a hint:

scw stuff create string=plop bool int=3
Error: arg 'bool' must have a value
Hint: try running: `scw stuff create string=plop bool=true int=3` 

Copy link
Copy Markdown
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois merged commit d8094d3 into scaleway:v2 Mar 12, 2020
@loicbourgois loicbourgois deleted the APIGW-1901 branch March 12, 2020 15:40
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants